Skip to content

Document System.Collections.Generic.IAsyncEnumera* and System.Drawing.Design.BitmapEditor #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2019
Merged

Document System.Collections.Generic.IAsyncEnumera* and System.Drawing.Design.BitmapEditor #2797

merged 2 commits into from
Jul 24, 2019
+4 −4

Conversation

carlossanlop
Copy link
Contributor

This PR should be quick.

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 labels Jul 22, 2019
@carlossanlop carlossanlop self-assigned this Jul 22, 2019
@rpetrusha rpetrusha added this to the July 2019 milestone Jul 23, 2019
rpetrusha
rpetrusha suggested changes Jul 23, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, @carlossanlop. I've left just one minor suggestion.

@carlossanlop
suggestions by rpetrusha
d4a14af 
Co-Authored-By: Ron Petrusha <[email protected]>
@carlossanlop carlossanlop added changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Jul 23, 2019
@carlossanlop carlossanlop requested a review from rpetrusha July 23, 2019 20:47
rpetrusha
rpetrusha approved these changes Jul 24, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this PR now, @carlossanlop.

@rpetrusha rpetrusha merged commit 49f6f10 into dotnet:master Jul 24, 2019
@carlossanlop carlossanlop deleted the collections_drawing branch July 24, 2019 20:34
@mairaw mairaw removed the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw Awaiting requested review from mairaw

@safern safern Awaiting requested review from safern

2 more reviewers

@maryamariyan maryamariyan maryamariyan approved these changes

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@carlossanlop carlossanlop

Labels
🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
July 2019
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossanlop @maryamariyan @rpetrusha @mairaw